Re: [PATCH v4 6/8] x86/ftrace: Use __pa_symbol instead of __pa on Cvisible symbols

From: Steven Rostedt
Date: Fri Nov 16 2012 - 18:30:21 EST


On Fri, 2012-11-16 at 15:06 -0800, H. Peter Anvin wrote:
> On 11/16/2012 02:45 PM, Steven Rostedt wrote:
> >
> > #define __pa(x) __phys_addr((unsigned long)(x))
> > #define __pa_symbol(x) __pa(__phys_reloc_hide((unsigned long)(x)))
> >
> > I'm confused. __pa_symbol() just calls __pa() with some macro magic to
> > its parameter. How is this a performance improvement?
> >
>
> One of the earlier patches in this series changes __pa_symbol() to avoid
> the conditional hidden inside __phys_addr(), since by definition a
> symbol can only be on one side of that branch.
>

Ah I missed the 6/8 reference and haven't looked at the rest of the
series.

OK, this makes sense now.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/