Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set whenBIT(0|1|2|3) of config is clear

[Sebastian Hesselbarth]

On 11/16/2012 10:12 AM, Axel Lin wrote:
> 2012/11/12 Sebastian Hesselbarth<sebastian.hesselbarth@xxxxxxxxx>:
> > On 11/11/2012 02:44 PM, Axel Lin wrote:
> > > Current implementation in dove_audio1_ctrl_set() does not clear
> > > corresponding
> > > register bit if BIT(0|1|2|3) of config is clear. Fix it.
> > >
> > > Signed-off-by: Axel Lin<axel.lin@xxxxxxxxxx>
> >
> >
> > Axel,
> >
> > thanks for the hint on not clearing the audio1 bits before setting them.
> > I will test this tonight and guess you should prepare a real patch for
> > this one.
>
> Hi Sebastian,
> Does this patch work for you?
> May I have your Acked-and-Tested-by if you think this patch is ok.

Axel,

pinctrl for Dove will not be enabled before DT clock support for Dove,
which will hopefully make it into 3.8. If you agree, I will test and push it
with the related patches for enabling pinctrl.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/