Re: [PATCH v3 6/9] rcu: use __this_cpu_read helper instead ofper_cpu_ptr(p, raw_smp_processor_id())

From: Paul E. McKenney
Date: Fri Nov 16 2012 - 13:10:08 EST


On Fri, Nov 16, 2012 at 05:42:14PM +0000, Christoph Lameter wrote:
>
> On Fri, 16 Nov 2012, Paul E. McKenney wrote:
>
> > If you either show me some significant performance benefits or get me
> > an independent Tested-by, in both cases on a range of hardware (e.g.,
> > x86 on the one hand and ARM or Power on the other), then I will queue it.
>
> Just putting the code generated for x86 before and after side
> by side would be enough to convince you I think.

If accompanied by similar before/after code for ARM or Power, sure.

Thanx, Paul

> > I wasn't prioritizing this one very high because it does not appear
> > to be on any sort of fastpath. If I am wrong about that, then you
> > have a good performance-benefit case, right? ;-)
>
> I do not think this needs to be a priority item. Just stick it in the tree
> somewhere to merge for the next merge period.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/