Re: [PATCH v2] LDT - Linux Driver Template

From: Greg KH
Date: Fri Nov 16 2012 - 07:07:46 EST


On Fri, Nov 16, 2012 at 10:46:18AM +0100, Bjørn Mork wrote:
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
>
> > Normally you just start with a
> > driver for a device like the one you need to write and modify it from
> > there.
>
> Yes.
>
> Even if the template driver is fixed up to be the most beautiful driver
> ever made, it will still always be made for non-existing hardware. This
> causes two major problems:
> - the driver will not be tested, so it will have bugs
> - the driver will not be used by anyone, so it will not be maintained
> (remember that it is initially perfect, so there is no reason to
> change it)
>
> May I suggest another approach? How about selecting a set of existing
> drivers which are suitable as templates, and put all this effort into
> making those drivers *the* perfect examples instead? Start submitting
> cleanup patches for the selected drivers until everyone is satisfied and
> then document them as starting points for anyone wanting to write a
> similar driver.

I agree, this is a much better idea. Basing any new driver on a
known-working driver is highly preferable.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/