Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit addressof FACS/DSDT all have value but not equal to each other

From: Ethan Zhao
Date: Thu Nov 15 2012 - 21:28:33 EST


Bob,
Thanks for your detailed reviewing about the whole possible conditions.
I.C. So that is impossible zero value for Xfacs /Xdsdt if
facs/dsdt >0, for they are assigned in acpi_tb_convert_fadt(), I need
to move my eyes one line code higher to see why it yelled twice
but not using the 32bit address at once in acpi_tb_convert_fadt().
Do you agree to move the checking code warning and into
acpi_tb_convert_fadt to make the code more simple and clear ? Or just
keep it for more rework, more bug?


Thanks,
Ethan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/