Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback()in serqt_usb2.c

[YAMANE Toshiaki]

On Fri, Nov 16, 2012 at 5:43 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Btw:
>> +             dev_dbg(&port->dev, "Line status status.\n");
>                                      ^^^^^^^^^^^^^^^^^^^
> These kind of debug statements which just tell which function is
> being called can be deleted.  The function tracer already provides
> that information.

I did not know that. Thanks!

>> +             fn = ProcessLineStatus;
>> +     } else {
>> +             dev_dbg(&port->dev, "Modem status status.\n");
>> +             fn = ProcessModemStatus;
>
> regards,
> dan carpenter
>



-- 

Regards,

YAMANE Toshiaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/