Re: [ 27/82] gpiolib: Dont return -EPROBE_DEFER to sysfs, or forinvalid gpios

[Herton Ronaldo Krzesinski]

On Wed, Nov 14, 2012 at 05:40:00AM +0000, Ben Hutchings wrote:
> 3.2-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> 
> commit ad2fab36d7922401c4576fb7ea9b21a47a29a17f upstream.
> 
> gpios requested with invalid numbers, or gpios requested from userspace via sysfs
> should not try to be deferred on failure.
> 
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpio/gpiolib.c |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 5d6c71e..1c8d9e3 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -623,9 +623,11 @@ static ssize_t export_store(struct class *class,
>  	 */
>  
>  	status = gpio_request(gpio, "sysfs");
> -	if (status < 0)
> +	if (status < 0) {
> +		if (status == -EPROBE_DEFER)

This one fails to build here:
linux/drivers/gpio/gpiolib.c: In function 'export_store':
linux/drivers/gpio/gpiolib.c:625:18: error: 'EPROBE_DEFER' undeclared (first use in this function)
linux/drivers/gpio/gpiolib.c:625:18: note: each undeclared identifier is reported only once for each function it appears in

There is no EPROBE_DEFER functionality on 3.2 and in gpio_request, so I
think the patch can be safely dropped.

[...]

-- 
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/