Re: [PATCH] drivers/net: fix tasklet misuse issue

From: David Miller
Date: Wed Nov 14 2012 - 21:50:46 EST


From: Xiaotian Feng <xtfeng@xxxxxxxxx>
Date: Wed, 14 Nov 2012 13:47:36 +0800

> In commit 175c0dff, drivers uses tasklet_kill to avoid put disabled tasklet
> on the tasklet vec. But some of the drivers uses tasklet_init & tasklet_disable
> in the driver init code, then tasklet_enable when it is opened. This makes
> tasklet_enable on a killed tasklet and make ksoftirqd crazy then. Normally,
> drivers should use tasklet_init/tasklet_kill on device open/remove, and use
> tasklet_disable/tasklet_enable on device suspend/resume.
>
> Reported-by: Peter Wu <lekensteyn@xxxxxxxxx>
> Tested-by: Peter Wu <lekensteyn@xxxxxxxxx>
> Signed-off-by: Xiaotian Feng <dannyfeng@xxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/