Re: [PATCH] drivers/of: Constify device_node->name and ->path_component_name

[Grant Likely]

On Wed, Nov 14, 2012 at 10:46 PM, Julian Calaby <julian.calaby@xxxxxxxxx> wrote:
> Hi Grant,
>
> On Thu, Nov 15, 2012 at 9:42 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>> On Wed, Nov 14, 2012 at 10:33 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>>>
>>> You're making other changes here, such as the kstrdup() stuff,
>>> seperate that into another patch.
>>
>> It's part of the same change. The original code was allocating a
>> buffer, saving the pointer in the name field and then modifying it.
>> Making the code to a kstrdup() gets rid of modifying the const buffer.
>
> You should really mention this in the commit log, maybe something like:
>
>
> [PATCH] drivers/of: Constify device_node->name and ->path_component_name
>
> Neither of these should ever be changed once set. Make them const
>
> Also use kstrdup() instead of memcpy() so we don't attempt to modify them.

Yup, will do.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/