Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT ifput_user fails

[Alan Cox]

On Wed, 14 Nov 2012 12:02:21 +0530
Kumar Amit Mehta <gmate.amit@xxxxxxxxx> wrote:

> This fix adds checks for inspecting the return value of put_user() and return
> -EFAULT on error.
> 
> Signed-off-by: Kumar Amit Mehta <gmate.amit@xxxxxxxxx>
> ---
>  drivers/staging/dgrp/dgrp_tty.c |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
> index e125b03..b294197 100644
> --- a/drivers/staging/dgrp/dgrp_tty.c
> +++ b/drivers/staging/dgrp/dgrp_tty.c
> @@ -2265,7 +2265,8 @@ static int get_modem_info(struct ch_struct *ch, unsigned int *value)
>  		| ((mlast & DM_RI)  ? TIOCM_RNG : 0)
>  		| ((mlast & DM_DSR) ? TIOCM_DSR : 0)
>  		| ((mlast & DM_CTS) ? TIOCM_CTS : 0);
> -	put_user(mlast, (unsigned int __user *) value);
> +	if (put_user(mlast, (unsigned int __user *) value))
> +		return -EFAULT;


	return put_user(mlast, ....)

is shorter and neater and does the same thing.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/