Re: [PATCH] mfd: arizona: Move chip reset to before register patch

[Charles Keepax]

On Wed, Nov 14, 2012 at 10:20:09AM +0900, Mark Brown wrote:
> On Tue, Nov 13, 2012 at 01:12:19PM +0000, Charles Keepax wrote:
> > On Tue, Nov 13, 2012 at 02:56:20PM +0900, Mark Brown wrote:
> 
> > > No, we should never write to the chip until we have successfully
> > > identified it.  Do a sync or similar instead (we should be triggering
> > > this very soon afterwards via runtime PM anyway).
> 
> > In that case I would be inclined to seperate out the chip
> > identification and the register patch doing the reset in between.
> > Is this something that would sound reasonable or would you rather
> > just add a sync after the reset?
> 
> Just do a sync, make sure that we mark the map as dirty when we do the
> reset via register write and it'll not have any effect anyway.  We
> should also check if we've got the LDO and use that for reset too
> actually...

The way the code is layed out at the moment if we don't
successfully get the LDO we won't get as far as the register
write reset. Meaning that if we can do the reset by cycling the
power on the LDO is there any point in having the option to do
the reset via a register write later?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/