Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only fornon-fixed regulators
From: Mark Brown
Date: Wed Nov 14 2012 - 02:29:02 EST
On Wed, Nov 14, 2012 at 03:11:37PM +0800, Kevin Liu wrote:
> - ret = regulator_set_voltage(host->vqmmc, 3300000, 3300000);
> + ret = regulator_set_voltage(host->vqmmc, 2700000, 3600000);
Should this be regulator_set_voltage_tol()? Otherwise it'd be good to
explain where the numbers come from.
> + ret = regulator_is_supported_voltage(host->vmmc, 1700000,
> + 1950000);
We should really add a regulator_is_supported_voltage_tol... let me
just do that.
Attachment:
signature.asc
Description: Digital signature