Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver

[Mark Brown]

On Tue, Nov 13, 2012 at 09:35:45PM -0500, Laxman Dewangan wrote:

> Yes, this is not a good idea, We will need support for wakeup
> without wakeup registers.
> Probably we need to add one more parameter, wake enable to control
> without wake_base.

This does not seem sensible.  Why would this be optional if it is
useful?  In any case, what you're doing in the driver here is clearly
not the way forward.

> >>There is 2 sets of registers which need to be configure, MASK and
> >>LINE enable.
> >So what does the second one do?

> The MASK register used for updating status register when interrupt
> occurs and LINE register used to pass the status to actual interrupt
> line.

So this sounds like the LINE register is actually the mask register
which is the opposite way around...  please describe this stuff in the
comments anyway.

Attachment: signature.asc
Description: Digital signature