Re: [PATCH 3/3] PM: Introduce Intel PowerClamp Driver

From: Paul E. McKenney
Date: Tue Nov 13 2012 - 20:36:17 EST


On Tue, Nov 13, 2012 at 05:14:50PM -0800, Jacob Pan wrote:
> On Tue, 13 Nov 2012 16:08:54 -0800
> Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:
>
> > > I think I know, but I feel the need to ask anyway. Why not tell
> > > RCU about the clamping?
> >
> > I don't mind telling RCU, but what cannot happen is a bunch of CPU
> > time suddenly getting used (since that is the opposite of what is
> > needed at the specific point in time of going idle)

Another round of RCU_FAST_NO_HZ rework, you are asking for? ;-)

> Another reason is my observation that there are some assumptions/checks
> to make sure only idle thread can tell rcu it is idle. Is it ok to
> extend that to other kthreads?

If you are only having the system take 6-millisecond "vacations", probably
best to try it as it is and fix specific problems if/when they arise.

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/