Re: [PATCH] x86/tlb: correct vmflag test for checking VM_HUGETLB

[Alex Shi]

On 11/13/2012 01:17 AM, Joonsoo Kim wrote:
> commit 611ae8e3f5204f7480b3b405993b3352cfa16662('enable tlb flush range
> support for x86') change flush_tlb_mm_range() considerably. After this,
> we test whether vmflag equal to VM_HUGETLB and it may be always failed,
> because vmflag usually has other flags simultaneously.
> Our intention is to check whether this vma is for hughtlb, so correct it
> according to this purpose.
> 
> Cc: Alex Shi <alex.shi@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Signed-off-by: Joonsoo Kim <js1304@xxxxxxxxx>
> 

Acked-by: Alex Shi <alex.shi@xxxxxxxxx>

> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 0777f04..60f926c 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -197,7 +197,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
>  	}
>  
>  	if (end == TLB_FLUSH_ALL || tlb_flushall_shift == -1
> -					|| vmflag == VM_HUGETLB) {
> +					|| vmflag & VM_HUGETLB) {
>  		local_flush_tlb();
>  		goto flush_all;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/