Re: [PATCH 28/46] x86, mm: Add pointer about Xen mmu requirementfor alloc_low_pages

[H. Peter Anvin]

On 11/13/2012 08:38 AM, Stefano Stabellini wrote:
> On Mon, 12 Nov 2012, Yinghai Lu wrote:
> > From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >
> > Add link to commit 279b706 for more information
> >
> > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>
> ah, here it is, OK then
>
> >   arch/x86/mm/init.c |    5 +++++
> >   1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> > index f5e0120..a7939ed 100644
> > --- a/arch/x86/mm/init.c
> > +++ b/arch/x86/mm/init.c
> > @@ -25,6 +25,11 @@ unsigned long __meminitdata pgt_buf_top;
> >
> >   static unsigned long min_pfn_mapped;
> >
> > +/*
> > + * Pages returned are already directly mapped.
> > + *
> > + * Changing that is likely to break Xen, see commit 279b706 for detail info.
>                                                                      ^detailed

When making references to git commits, please include the title of the 
commit:

 *
 * Changing that is likely to break Xen, see commit:
 *
 *    279b706 x86,xen: introduce x86_init.mapping.pagetable_reserve
 *
 * for detailed information.

Otherwise it might be very confusing if we have an abbreviated hash 
collision or end up having to change git to use another hash system.

	-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/