Re: [PATCH 12/19] mm: migrate: Introduce migrate_misplaced_page()

[Rik van Riel]

On 11/13/2012 06:43 AM, Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> > * Mel Gorman <mgorman@xxxxxxx> wrote:
> >
> > > From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > >
> > > Note: This was originally based on Peter's patch "mm/migrate: Introduce
> > > 	migrate_misplaced_page()" but borrows extremely heavily from Andrea's
> > > 	"autonuma: memory follows CPU algorithm and task/mm_autonuma stats
> > > 	collection". The end result is barely recognisable so signed-offs
> > > 	had to be dropped. If original authors are ok with it, I'll
> > > 	re-add the signed-off-bys.
> > >
> > > Add migrate_misplaced_page() which deals with migrating pages from
> > > faults.
> > >
> > > Based-on-work-by: Lee Schermerhorn <Lee.Schermerhorn@xxxxxx>
> > > Based-on-work-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > > Based-on-work-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> > > Signed-off-by: Mel Gorman <mgorman@xxxxxxx>
> > > ---
> > >   include/linux/migrate.h |    8 ++++
> > >   mm/migrate.c            |  104 ++++++++++++++++++++++++++++++++++++++++++++++-
> > >   2 files changed, 110 insertions(+), 2 deletions(-)
> >
> > That's a nice patch - the TASK_NUMA_FAULT approach in the
> > original patch was not very elegant.
> >
> > I've started testing it to see how well your version works.
>
> Hm, I'm seeing some instability - see the boot crash below. If I
> undo your patch it goes away.
>
> ( To help debugging this I've attached migration.patch which
>    applies your patch on top of Peter's latest queue of patches.
>    If I revert this patch then the crash goes away. )
>
> I've gone back to the well-tested page migration code from Peter
> for the time being.

Is there a place we can see your code?

Peter's patch with MIGRATE_FAULT is very much NAKed, so
this approach does need to be made to work...

You can either make the working tree public somewhere,
so we can help, or figure it out yourself. Your choice :)

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/