RE: [PATCH 1/1] mm: Export a function to read vm_committed_as

[KY Srinivasan]

> -----Original Message-----
> From: David Rientjes [mailto:rientjes@xxxxxxxxxx]
> Sent: Monday, November 12, 2012 4:54 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> andi@xxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx;
> kamezawa.hiroyuki@xxxxxxxxx; mhocko@xxxxxxx; hannes@xxxxxxxxxxx;
> yinghan@xxxxxxxxxx
> Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as
> 
> On Sun, 11 Nov 2012, KY Srinivasan wrote:
> 
> > Thanks for the prompt response. For the Linux balloon driver for Hyper-V, I
> need access
> > to the metric that reflects the system wide memory commitment made by the
> guest kernel.
> > In the Hyper-V case, this information is one of the many metrics used to drive
> the policy engine
> > on the host. Granted, the interface name I have chosen here could be more
> generic; how about
> > read_mem_commit_info(void). I am open to suggestions here.
> >
> 
> I would suggest vm_memory_committed() and there shouldn't be a comment
> describing that this is just a wrapper for modules to read
> vm_committed_as, that's apparent from the implementation: it should be
> describing exactly what this value represents and why it is a useful
> metric (at least in the case that you're concerned about).

Will do; thanks.
> 
> > With regards to making changes to the Xen self ballooning code, I would like to
> separate that patch
> > from the patch that implements the exported mechanism to access the
> memory commitment information.
> 
> Why?  Is xen using it for a different inference?

I think it is good to separate these patches. Dan (copied here) wrote the code for the
Xen self balloon driver. If it is ok with him I can submit the patch for Xen as well. 


Regards,

K. Y



> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/