Re: [PATCH 1/9 v3] cgroup: add cgroup_subsys->post_create()

[Daniel Wagner]

Hi Tejun,

On 09.11.2012 18:22, Tejun Heo wrote:
> Hey, Daniel.
>
> On Fri, Nov 09, 2012 at 12:09:38PM +0100, Daniel Wagner wrote:
> > On 08.11.2012 20:07, Tejun Heo wrote:> Subject: cgroup: add
> > cgroup_subsys->post_create()
> > > Currently, there's no way for a controller to find out whether a new
> > > cgroup finished all ->create() allocatinos successfully and is
> > > considered "live" by cgroup.
> >
> > I'd like add hierarchy support to net_prio and the first thing to
> > do is to get rid of get_prioidx(). It looks like it would be nice to
>
> Ooh, I'm already working on it.  I *think* I should be able to post
> the patches later today or early next week.

No problem. I didn't spend too much time in writing the patch. Getting
rid of get_prioidx() was simple. I just wanted to help out, but then
I might to slow to keep up with you :)

Though I have a question on the patch you are writing. When you disable
broken_hierarchy for the networking controllers, are you also 
considering to disable them on the root cgroup? Currently both
net_prio and net_cls will do work on the root cgroup. I think for
harmonizing the behavior or all controllers this should also be
disabled.

> > be able to use use_id and post_create() for this but as I read the
> > code this might not work because the netdev might access resources
> > allocated between create() and post_create(). So my question is
> > would it make sense to move
> >
> > cgroup_create():
> >
> > 		if (ss->use_id) {
> > 			err = alloc_css_id(ss, parent, cgrp);
> > 			if (err)
> > 				goto err_destroy;
> > 		}
> >
> > part before create() or add some protection between create() and
> > post_create() callback in net_prio. I have a patch but I see
> > I could drop it completely if post_create() is there.
>
> Glauber had about similar question about css_id and I need to think
> more about it but currently I think I want to phase out css IDs.  It's
> an id of the wrong thing (CSSes don't need IDs, cgroups do) and
> unnecessarily duplicates its own hierarchy when the hierarchy of
> cgroups already exists.  Once memcontrol moves away from walking using
> css_ids, I *think* I'll try to kill it.
>
> I'll add cgroup ID (no hierarchy funnies, just a single ida allocated
> number) so that it can be used for cgroup indexing.  Glauber, that
> should solve your problem too, right?

net_prio doesn't have any particular requirements on the indexing, 
unless there is one. So a global ida would work for net_prio.

cheers,
daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/