RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

From: Mathias LEBLANC
Date: Mon Nov 12 2012 - 04:27:59 EST


Variable interrupts value must be 0 or 1. This restriction is defined by the fact of using the bool parameter (true or false)

Regards,

Mathias Leblanc
________________________________________
From: Rusty Russell [rusty@xxxxxxxxxx]
Sent: 08 November 2012 13:18
To: Mathias LEBLANC; Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx; Jean-Luc BLANC; Mathias LEBLANC
Subject: Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

Mathias Leblanc <mathias.leblanc@xxxxxx> writes:
> +static int interrupts ;
> +module_param(interrupts, bool, 0444);
> +MODULE_PARM_DESC(interrupts, "Enable interrupts");
> +
> +static int power_mgt = 1;
> +module_param(power_mgt, bool, 0444);
> +MODULE_PARM_DESC(power_mgt, "Power Management");

These are not bools, so why does module_param describe them as bool?

Cheers,
Rusty.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/