Re: [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX &&PINCONF

[Shawn Guo]

On Sun, Nov 11, 2012 at 10:22:42AM +0800, Axel Lin wrote:
> Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}.
> This simplifies the dependency.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
>  drivers/pinctrl/Kconfig |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index fc0f49a..d5c9431 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -99,18 +99,16 @@ config PINCTRL_MMP2
>  	select PINCONF
>  
>  config PINCTRL_MXS
> +	select PINMUX
> +	select PINCONF

Better have them after 'bool' below, otherwise,

Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

>  	bool
>  
>  config PINCTRL_IMX23
>  	bool
> -	select PINMUX
> -	select PINCONF
>  	select PINCTRL_MXS
>  
>  config PINCTRL_IMX28
>  	bool
> -	select PINMUX
> -	select PINCONF
>  	select PINCTRL_MXS
>  
>  config PINCTRL_NOMADIK
> -- 
> 1.7.9.5
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/