Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks

[Geert Uytterhoeven]

Ping? (akpm added to CC)

On Mon, Oct 15, 2012 at 10:44 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Older gcc (< 4.4) doesn't like files starting with Unicode BOMs:
>
> include/linux/mfd/da9055/core.h:1: error: stray â\357â in program
> include/linux/mfd/da9055/core.h:1: error: stray â\273â in program
> include/linux/mfd/da9055/core.h:1: error: stray â\277â in program
> include/linux/mfd/da9055/pdata.h:1: error: stray â\357â in program
> include/linux/mfd/da9055/pdata.h:1: error: stray â\273â in program
> include/linux/mfd/da9055/pdata.h:1: error: stray â\277â in program
> include/linux/mfd/da9055/reg.h:1: error: stray â\357â in program
> include/linux/mfd/da9055/reg.h:1: error: stray â\273â in program
> include/linux/mfd/da9055/reg.h:1: error: stray â\277â in program
>
> Remove the BOMs, the rest of the files is plain ASCII anyway.
>
> Output of "file" before:
>
> include/linux/mfd/da9055/core.h:  UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/reg.h:   UTF-8 Unicode (with BOM) C program text
>
> Output of "file" after:
>
> include/linux/mfd/da9055/core.h:  ASCII C program text
> include/linux/mfd/da9055/pdata.h: ASCII C program text
> include/linux/mfd/da9055/reg.h:   ASCII C program text
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
>  include/linux/mfd/da9055/core.h  |    2 +-
>  include/linux/mfd/da9055/pdata.h |    2 +-
>  include/linux/mfd/da9055/reg.h   |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mfd/da9055/core.h b/include/linux/mfd/da9055/core.h
> index c96ad68..956afa4 100644
> --- a/include/linux/mfd/da9055/core.h
> +++ b/include/linux/mfd/da9055/core.h
> @@ -1,4 +1,4 @@
> -ï/*
> +/*
>   * da9055 declarations for DA9055 PMICs.
>   *
>   * Copyright(c) 2012 Dialog Semiconductor Ltd.
> diff --git a/include/linux/mfd/da9055/pdata.h b/include/linux/mfd/da9055/pdata.h
> index 147293b..b9b204e 100644
> --- a/include/linux/mfd/da9055/pdata.h
> +++ b/include/linux/mfd/da9055/pdata.h
> @@ -1,4 +1,4 @@
> -ï/* Copyright (C) 2012 Dialog Semiconductor Ltd.
> +/* Copyright (C) 2012 Dialog Semiconductor Ltd.
>   *
>   *  This program is free software; you can redistribute it and/or modify
>   *  it under the terms of the GNU General Public License as published by
> diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h
> index df237ee..2b592e0 100644
> --- a/include/linux/mfd/da9055/reg.h
> +++ b/include/linux/mfd/da9055/reg.h
> @@ -1,4 +1,4 @@
> -ï/*
> +/*
>   * DA9055 declarations for DA9055 PMICs.
>   *
>   * Copyright(c) 2012 Dialog Semiconductor Ltd.
> --
> 1.7.0.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/