Re: [PATCH] USB: mos7840: remove unused variable

From: Jiri Slaby
Date: Sat Nov 10 2012 - 17:28:55 EST


On 11/08/2012 06:28 PM, Johan Hovold wrote:
> Fix warning about unused variable introduced by commit e681b66f2e19fa
> ("USB: mos7840: remove invalid disconnect handling") upstream.
>
> A subsequent fix which removed the disconnect function got rid of the
> warning but that one was only backported to v3.6.
>
> Reported-by: Jiri Slaby <jslaby@xxxxxxx>

FWIW Looks good to me.

> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> ---
>
> This patch against v3.4 also applies to v3.0 (and v3.2).
>
> Thanks,
> Johan
>
> drivers/usb/serial/mos7840.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 0179d34..c854235 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2581,7 +2581,6 @@ error:
> static void mos7840_disconnect(struct usb_serial *serial)
> {
> int i;
> - unsigned long flags;
> struct moschip_port *mos7840_port;
> dbg("%s", " disconnect :entering..........");
>

thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/