Re: [PATCH] dmaengine/dmatest: terminate transfers only in case oferrors

[Dan Williams]

On 11/9/12 7:26 AM, "Viresh Kumar" <viresh.kumar@xxxxxxxxxx> wrote:

>From: Shiraz Hashim <shiraz.hashim@xxxxxx>
>
>dmatest erroneously terminated transfers in normal cases also leading to
>test failures for multiple threads over a channel. Fix this and
>terminate transfers only in case of errors.
>
>Signed-off-by: Shiraz Hashim <shiraz.hashim@xxxxxx>
>Signed-off-by: Deepak Sikri <deepak.sikri@xxxxxx>
>---
> drivers/dma/dmatest.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
>index 8f130d4e..ce58b8e 100644
>--- a/drivers/dma/dmatest.c
>+++ b/drivers/dma/dmatest.c
>@@ -509,7 +509,9 @@ err_srcs:
> 			thread_name, total_tests, failed_tests, ret);
> 
> 	/* terminate all transfers on specified channels */
>-	chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
>+	if (ret)
>+		chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
>+

This and commit 9704efa "dmaengine/dmatest: Terminate transfers on all
channels in case of error or exit" are broken for channels that don't
implement the optional ->device_control.  Care to fix that up?


--
Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/