Re: [PATCH 2/2] drm: tegra: Add HDMI support

[Christian KÃnig]

On 09.11.2012 16:45, RafaÅ MiÅecki wrote:
> 2012/11/9 Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>:
> > +/* all fields little endian */
> > +struct hdmi_audio_infoframe {
> > +       /* PB0 */
> > +       u8 csum;
> > +
> > +       /* PB1 */
> > +       unsigned cc:3; /* channel count */
> > +       unsigned res1:1;
> > +       unsigned ct:4; /* coding type */
> > +
> > +       /* PB2 */
> > +       unsigned ss:2; /* sample size */
> > +       unsigned sf:3; /* sample frequency */
> > +       unsigned res2:3;
> > +
> > +       /* PB3 */
> > +       unsigned cxt:5; /* coding extention type */
> > +       unsigned res3:3;
> > +
> > +       /* PB4 */
> > +       u8 ca; /* channel/speaker allocation */
> > +
> > +       /* PB5 */
> > +       unsigned res5:3;
> > +       unsigned lsv:4; /* level shift value */
> > +       unsigned dm_inh:1; /* downmix inhibit */
> > +
> > +       /* PB6-10 reserved */
> > +       u8 res6;
> > +       u8 res7;
> > +       u8 res8;
> > +       u8 res9;
> > +       u8 res10;
> > +} __packed;
> I was told it won't work on different endian devices. See
> [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe
> http://lists.freedesktop.org/archives/dri-devel/2012-May/022544.html

Yeah, that's indeed true. And honestly adding just another 
implementation of the HDMI info frames sounds like somebody should 
finally sit down and implement it in a common drm_hdmi.c

Regards,
Christian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/