Re: [PATCH v2 06/10] pwm: pwm-tiehrpwm: Add device-tree bindingsupport for EHRPWM driver

From: Thierry Reding
Date: Fri Nov 09 2012 - 03:07:40 EST


On Thu, Nov 08, 2012 at 01:23:13PM +0530, Philip, Avinash wrote:
> This patch
> 1. Add support for device-tree binding for EHRWPM driver.
> 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM
> period & polarity configuration from device tree.
> 3. Add enable/disable clock gating in PWM subsystem common config space.
> 4. When here set .owner member in platform_driver structure to
> THIS_MODULE.
>
> Signed-off-by: Philip, Avinash <avinashphilip@xxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Rob Landley <rob@xxxxxxxxxxx>
> ---
> Changes since v1:
> - Add separate patch for pinctrl support
> - Add conditional check for PWM subsystem clock enable.
> - Combined with HWMOD changes & DT bindings.
> - Remove the custom of xlate support.
>
> :000000 100644 0000000... aa2ed0a... A Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> :100644 100644 d3c1dff... fba7f9b... M drivers/pwm/pwm-tiehrpwm.c
> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 25 ++++++++++
> drivers/pwm/pwm-tiehrpwm.c | 49 +++++++++++++++++++-
> 2 files changed, 72 insertions(+), 2 deletions(-)

The same comments apply as for the pwm-tiecap driver patch.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature