[PATCH 4/8] aoe: err device: include MAC addresses for unexpected responses

From: Ed Cashin
Date: Thu Nov 08 2012 - 19:23:52 EST


The /dev/etherd/err character device provides low-level
information about normal but sometimes interesting AoE command
retransmits and "unexpected responses", i.e., responses for
packets that have already been retransmitted.

This change adds MAC addresses to the messages about unexpected
responses, so that when they occur, it's more easy to determine
the network paths to which they belong.

Signed-off-by: Ed Cashin <ecashin@xxxxxxxxxx>
---
drivers/block/aoe/aoecmd.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index f849fa2..6ea27fd 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -1204,12 +1204,14 @@ aoecmd_ata_rsp(struct sk_buff *skb)
spin_unlock_irqrestore(&d->lock, flags);
aoedev_put(d);
snprintf(ebuf, sizeof(ebuf),
- "%15s e%d.%d tag=%08x@%08lx\n",
+ "%15s e%d.%d tag=%08x@%08lx s=%pm d=%pm\n",
"unexpected rsp",
get_unaligned_be16(&h->major),
h->minor,
get_unaligned_be32(&h->tag),
- jiffies);
+ jiffies,
+ h->src,
+ h->dst);
aoechr_error(ebuf);
return skb;
}
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/