On 10/25/2012 9:41 PM, Murali Karicheri wrote:Will fix
pll dividers are present in the pll controller of DaVinci and Otherincomplete sentence.
SoCs that re-uses the same hardware IP. This has a enable bit for
bypass the divider or enable the driver. This is a sub class of the
clk-divider clock checks the enable bit to calculare the rate and
invoke the recalculate() function of the clk-divider if enabled.
Signed-off-by: Murali Karicheri <m-karicheri2@xxxxxx>
---
drivers/clk/davinci/clk-div.c | 124 +++++++++++++++++++++++++++++++++++++++++
drivers/clk/davinci/clk-div.h | 42 ++++++++++++++
2 files changed, 166 insertions(+)
create mode 100644 drivers/clk/davinci/clk-div.c
create mode 100644 drivers/clk/davinci/clk-div.h
diff --git a/drivers/clk/davinci/clk-div.c b/drivers/clk/davinci/clk-div.c
new file mode 100644
index 0000000..8147d99
--- /dev/null
+++ b/drivers/clk/davinci/clk-div.c
@@ -0,0 +1,124 @@
+/*
+ * Copyright 2012 Freescale Semiconductor, Inc.
+ * Copyright 2012 Texas instuments
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
I did a grep in the drivers/clk directory. All of the platform drivers are having the device ptr and all of them are called with NULL. I am not sure what is the intent of this arg in the API. As per documentation of the clk_register() API, the device ptr points to the device that is registering this clk. So if a specific device driver ever has to register a PLL div clk, this will be non NULL. In the normal use case, clk is registered in a platform specific code and is always passed NULL.
+/**Why do you need a dev pointer here and which device does it point to? In
+ * clk_register_davinci_plldiv - register function for DaVinci PLL divider clk
+ *
+ * @dev: device ptr
+ * @name: name of the clock
+ * @parent_name: name of parent clock
+ * @plldiv_data: ptr to pll divider data
+ * @lock: ptr to spinlock passed to divider clock
+ */
+struct clk *clk_register_davinci_plldiv(struct device *dev,
the only usage of this API in the series, you pass a NULL here. I should
have probably asked this question on one of the earlier patches itself.
Shouldn't you be calling clk_register_divider() here which in turn willAs stated in the top of the file, this is a subclass driver of clk-div similar in line with mxs/clk-div.c. The
do clk_register()?
Thanks,
Sekhar