Re: [PATCH] kbuild: Fix gcc -x syntax

From: Bernhard Walle
Date: Sat Sep 29 2012 - 04:31:50 EST


Hi,

* Ingo Molnar <mingo@xxxxxxxxxx> [2012-09-29 08:37]:
> * Jean Delvare <jdelvare@xxxxxxx> wrote:
>
> > The correct syntax for gcc -x is "gcc -x assembler", not "gcc
> > -xassembler". Even though the latter happens to work, the
> > former is what is documented in the manual page and thus what
> > gcc wrappers such as icecream do expect.
> >
> > This isn't a cosmetic change. The missing space prevents
> > icecream from recognizing compilation tasks it can't handle,
> > leading to silent kernel miscompilations.
>
> Although we can apply this patch, it won't solve the problem of
> building older kernels (and bisecting, etc.).
>
> Wouldn't it be prudent to increase the compatibility of
> icecream, so that it accepts what GCC accepts in practice,
> such as -xassembler?

Wouldn't it make sense to do both? Using the documented syntax in the
build system *and* increase compatibility in 3rd party tools?


Regards,
Bernhard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/