Re: [PATCH 17/57] power: ab8500_bm: Added support for BATT_OVV

[Anton Vorontsov]

On Fri, Sep 28, 2012 at 12:24:53PM -0600, Mathieu Poirier wrote:
[...]
> >>  		/* Not yet recovered from ovv, reschedule this test */
> >>  		queue_delayed_work(di->fg_wq, &di->fg_check_hw_failure_work,
> >> -				   round_jiffies(HZ));
> >> +			HZ);
> > 
> > Why this change? I.e. round_jiffies(HZ) -> HZ?
> > 
> > Yes, it seems like round_jiffies(HZ) is not needed since HZ itself is a
> > full second.. But the change itself does not belong to this patch.
> 
> I agree with your point of view.  How do we fix it now ?  Do you think
> it's worth crafting a one-line patch ?

Yup. Or you can leave the code as is: I guess round_jiffies() is not a big
deal since it's not in some kind of hot path, so generally this doesn't
affect behaviour. It's up to you, I'm fine either way.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/