Re: [PATCH 02/31] perf, x86: Basic Haswell PMU support

From: Andi Kleen
Date: Fri Sep 28 2012 - 10:58:33 EST


On Fri, Sep 28, 2012 at 11:05:45AM +0200, Peter Zijlstra wrote:
> On Thu, 2012-09-27 at 21:31 -0700, Andi Kleen wrote:
> > /*
> > + * Also filter out TSX bits.
> > + */
> > +#define TSX_FIXED_EVENT_CONSTRAINT(c, n) \
> > + EVENT_CONSTRAINT(c, (1ULL << (32+n)), \
> > + X86_RAW_EVENT_MASK|HSW_INTX|HSW_INTX_CHECKPOINTED)
>
> How volatile are those bits? Will the re-appear in future chips or are
> they prone to get re-assigned different semantics in future chips?

Traditionally these bits have been fairly stable.

>
> If they're 'stable' we might as well add then to FIXED_EVENT_CONSTRAINT,
> its not like those bits would ever appear on previous hardware.

Ok will do.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/