Re: [PATCH] pinctrl/nomadik: allocate IRQ descriptors dynamically

From: Linus Walleij
Date: Thu Sep 27 2012 - 08:48:06 EST


On Thu, Sep 27, 2012 at 2:37 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:

>> nmk_chip->domain = irq_domain_add_legacy(np, NMK_GPIO_PER_CHIP,
>
> You might as well change to irq_domain_add_simple here.

True. I'll fix.

> Perhaps we should just add irq_alloc_descs call into
> irq_domain_add_simple in the legacy case. It may need to be conditioned
> on SPARSE_IRQ. There's currently no callers, so it wouldn't break anything.

OK get ready to ACK, I'll fix.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/