Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

From: viresh kumar
Date: Thu Sep 27 2012 - 04:17:55 EST


On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote:
>> From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>>
>> This driver could be used on different platforms. Thus, the HAVE_CLK dependency
>> is dropped away.
>>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> ---
>> drivers/dma/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> index 677cd6e..df32537 100644
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA
>>
>> config DW_DMAC
>> tristate "Synopsys DesignWare AHB DMA support"
>> - depends on HAVE_CLK
>
> as is, this will break compilation of any arch which doesn't set
> HAVE_CLK.

No, it will not due to following commit id:

commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1
Author: Viresh Kumar <viresh.kumar@xxxxxx>
Date: Mon Jul 30 14:39:27 2012 -0700

clk: add non CONFIG_HAVE_CLK routines


@Andy:

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/