Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

From: viresh kumar
Date: Thu Sep 27 2012 - 04:16:13 EST


On Thu, Sep 27, 2012 at 1:10 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c

>> @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table);
>> #endif
>>
>> static struct platform_driver dw_driver = {
>> + .probe = dw_probe,
>
> probe's in __init section. This is wrong. You need to change probe
> __devinit.

Good one. How can i miss it. :(

@Andy: Please add my Acked-by: after this change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/