Re: [PATCH 01/10] UBI: Add fastmap on-flash data structures

From: Artem Bityutskiy
Date: Wed Sep 26 2012 - 06:33:07 EST


On Mon, 2012-09-24 at 20:31 +0200, Richard Weinberger wrote:
> Add the on-flash data structures neeed by fastmap
> to ubi-media.h
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>

Richard, thanks, here is the deal I suggest

1. I do not really have time to review this in details.
2. I do not want to block this either
3. I want to merge this to 3.7 with come pre-conditions (see below)
as "Experimental" with a claim that the on-flash format can
be changed. Something like Linus did for btrfs. Then let people
play with fastmap. I am sure it'll need changes when people
try to use it in production.

a. Aiaiai is happy
b. You provide a section for the mtd web site describing fastmap
c. It does not break anything when it is disabled
d. When it is enabled, it also passes the UBI tests

Actually, I want to expose it to linux-next already after step a.
Despite a lot of testing you have already done, I am willing to do some
testing myself as well, so I'll do c. and d. and let you know if there
are issues.

Could you please do b. ?

--
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part