Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

From: Peter Zijlstra
Date: Mon Sep 24 2012 - 05:13:18 EST


On Sun, 2012-09-23 at 22:19 +0200, Oleg Nesterov wrote:

> @@ -226,6 +245,10 @@ retry:

Could you use:

$ cat ~/.gitconfig
[diff "default"]
xfuncname = "^[[:alpha:]$_].*[^:]$"

This avoids git-diff it using labels as function names.

> if (ret <= 0)
> return ret;
>
> + ret = verify_opcode(old_page, vaddr, &opcode);
> + if (ret <= 0)
> + goto put_old;
> +
> ret = -ENOMEM;
> new_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vaddr);
> if (!new_page)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/