Re: [PATCH tip/core/rcu 23/23] rcu: Simplify quiescent-statedetection

From: Peter Zijlstra
Date: Thu Sep 06 2012 - 10:37:42 EST


On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paul.mckenney@xxxxxxxxxx>
>
> The current quiescent-state detection algorithm is needlessly
> complex.

Heh! Be careful, we might be led into believing all this RCU is actually
really rather simple and this complexity is a bug on your end ;-)

> It records the grace-period number corresponding to
> the quiescent state at the time of the quiescent state, which
> works, but it seems better to simply erase any record of previous
> quiescent states at the time that the CPU notices the new grace
> period. This has the further advantage of removing another piece
> of RCU for which lockless reasoning is required.

So why didn't you do that from the start? :-)

That is, I'm curious to know some history, why was it so and what led
you to this insight?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/