Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

From: Krystian Garbaciak
Date: Fri Aug 31 2012 - 06:06:16 EST


> On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote:
>
> > Because, for some regulators, this is required: val += fvol->offset,
> > I was only able to reduce it to the following form.
>
> What on earth makes you say this? The above is obviously linear.
>
> Besides, you're missing several points here. One is that you should be
> using the framework features, another is that you should be implementing
> _sel.

Sorry, I've missed an obvious thing here. Instead of adding selector offset at
runtime, I can substract apropriate voltage from .min_uV. Thanks for pointing
this out.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/