Re: [PATCH 5/8] hpfs: drop lock/unlock super

From: Mikulas Patocka
Date: Thu Aug 30 2012 - 19:59:05 EST


It looks ok.

Mikulas

On Thu, 30 Aug 2012, Marco Stornelli wrote:

> Removed lock/unlock super.
>
> Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> ---
> fs/hpfs/super.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index 706a12c..8af2cdc 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -389,7 +389,6 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
> *flags |= MS_NOATIME;
>
> hpfs_lock(s);
> - lock_super(s);
> uid = sbi->sb_uid; gid = sbi->sb_gid;
> umask = 0777 & ~sbi->sb_mode;
> lowercase = sbi->sb_lowercase;
> @@ -422,12 +421,10 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
>
> replace_mount_options(s, new_opts);
>
> - unlock_super(s);
> hpfs_unlock(s);
> return 0;
>
> out_err:
> - unlock_super(s);
> hpfs_unlock(s);
> kfree(new_opts);
> return -EINVAL;
> --
> 1.7.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/