Re: [PATCH tip/core/rcu 0/5] Documentation and rcutorture changes

From: Josh Triplett
Date: Thu Aug 30 2012 - 19:23:08 EST


On Thu, Aug 30, 2012 at 02:46:03PM -0700, Paul E. McKenney wrote:
> On Thu, Aug 30, 2012 at 11:56:09AM -0700, Josh Triplett wrote:
> > On Thu, Aug 30, 2012 at 11:44:48AM -0700, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > This series covers changes to rcutorture and documentation updates.
> > > The individual patches in this series are as follows:
> > >
> > > 1. Update rcutorture default values so that casual rcutorture
> > > users will do more aggressive testing.
> > > 2. Make rcutorture track CPU-hotplug latency statistics.
> > > 3. Document SRCU's new-found ability to be used by offline and
> > > idle CPUs, and also emphasize SRCU's limitations.
> > > 4. Use the new pr_*() interfaces in rcutorture.
> > > 5. Prevent kthread-initialization races in rcutorture.
> > >
> > > Thanx, Paul
> > >
> > > ------------------------------------------------------------------------
> > >
> > > b/Documentation/RCU/checklist.txt | 6 +
> > > b/Documentation/RCU/whatisRCU.txt | 9 +-
> > > b/kernel/rcutorture.c | 4 -
> > > kernel/rcutorture.c | 152 +++++++++++++++++++++++---------------
> > > 4 files changed, 108 insertions(+), 63 deletions(-)
> >
> > Something seems wrong with this diffstat; how'd the b/ prefixes get
> > there, and why does it list kernel/rcutorture.c twice, once with and
> > once without?
>
> Hmmm... It seems quite reproducible. I did the usual git-format-patch
> and ran the resulting set of patches through diffstat. I seem to have a
> broken diffstat...
>
> However, git diff --stat v3.6-rc1..hotplug.2012.08.28a generates the
> following:
>
> kernel/rcutree.c | 93 +++++++++++-------------------------------------
> kernel/rcutree.h | 3 --
> kernel/rcutree_trace.c | 4 +-
> kernel/sched/core.c | 41 ++++++++++-----------
> 4 files changed, 43 insertions(+), 98 deletions(-)
>
> Which does look much better.

You might try generating your cover letter template via git format-patch
--cover-letter, which will automatically give you a list of patches and
a git-produced diffstat; much easier than trying to format a cover
letter by hand. Meanwhile, you might consider sending your patches as a
bug report to diffstat upstream: Thomas E. Dickey
<dickey@xxxxxxxxxxxxxxxxxxxx>.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/