Re: [PATCH] lp8727_charger: use IRQF_ONESHOT

[Anton Vorontsov]

On Thu, Aug 30, 2012 at 11:41:54AM +0000, Kim, Milo wrote:
> > > ERROR: Threaded IRQ with no primary handler requested without
> > > IRQF_ONESHOT
> > >
> > > Make sure threaded IRQs without a primary handler are always request
> > > with IRQF_ONESHOT
> > >
> > > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> > > ---
> > >
> > > Note: I don't really know much about the situation, feel free to
> > > ignore it if it's an false warning.
> > >
> > >  cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/drivers/power/lp8727_charger.c
> > > +++ b/drivers/power/lp8727_charger.c
> > > @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
> > >  	return request_threaded_irq(pchg->client->irq,
> > >  				NULL,
> > >  				lp8727_isr_func,
> > > -				IRQF_TRIGGER_FALLING,
> > > +				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > >  				"lp8727_irq",
> > >  				pchg);
> > >  }
> > Thanks for the update.
> > 
> > Acked-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
> > 
> 
> Please refer to the patch below.
> [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
> This includes previous Fengguang' patch.

Nope, I'll include Fengguang's patch (he posted it first), and then
will try to apply the rest of your cleanups on top of it. If it helps,
your can incorporate the fix in your series, preserving the authorship.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/