Re: [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs

From: Pekka Enberg
Date: Thu Aug 30 2012 - 06:15:18 EST


On Wed, Aug 29, 2012 at 2:41 PM, Haggai Eran <haggaie@xxxxxxxxxxxx> wrote:
>> Looks like a problem in 072bb0aa5e0 ("mm: sl[au]b: add knowledge of
>> PFMEMALLOC reserve pages"). cache_grow() can reenable irqs which allows
>> this to be scheduled on a different cpu, possibly with a different node.
>> So it turns out that we lock the wrong node's list_lock because we don't
>> check the new node id when irqs are disabled again.
>>
>> I doubt you can reliably reproduce this, but the following should fix the
>> issue.
> Your patch did solve the issue. Thanks!

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/