Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

[Thomas Abraham]

On 28 August 2012 04:52, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Aug 21, 2012 at 9:22 PM, Thomas Abraham
> <thomas.abraham@xxxxxxxxxx> wrote:

[...]

>>>> +/* list of all possible config options supported */
>>>> +struct pin_config {
>>>> +       char            *prop_cfg;
>>>> +       unsigned int    cfg_type;
>>>> +} pcfgs[] = {
>>>> +       { "samsung,pin-pud", PINCFG_TYPE_PUD },
>>>> +       { "samsung,pin-drv", PINCFG_TYPE_DRV },
>>>> +       { "samsung,pin-pud-pdn", PINCFG_TYPE_CON_PND },
>>>> +       { "samsung,pin-drv-pdn", PINCFG_TYPE_PUD_PND },
>>>> +};
>>>
>>> Hmmmmm it looks very much like this controller could make use of
>>> the generic pinconf library, but it's not mandatory so just a suggestion.
>>
>> Ok. The last two entries in the above table are Samsung specific and
>> not covered by generic-pinconf. So, I am not sure if it can be added
>> to generic-pinconf.
>
> What is so Samsung-specific about them?
>
> If you tell us the electrical property of setting them we can figure out
> if they should be generic or not...
>

The PINCFG_TYPE_CON_PND and PINCFG_TYPE_PUD_PND are "mux function" and
"pull up/down" settings that are automatically applied to the pin in
powert-down mode. It is same as the usual "mux function" and "pull
up/down" settings, but just that it is applied at suspend.

[...]

>
> OK whatever... looking formward to next iteration!

I have posted the updated version of this patch series based on your
comments (https://lkml.org/lkml/2012/8/23/183).

The only pending comment to be addressed at this point is about the
use of generic-pinconf as mentioned in the comment above. If
PINCFG_TYPE_CON_PND and PINCFG_TYPE_PUD_PND is available in
generic-pinconf, I wil switch to using generic-pinconf. Will that
qualify this Samsung pinctrl driver to be merged into your -devel
branch?

Thanks,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/