Re: [RFC PATCH 4/17] input: RMI4 configs and makefiles

[Linus Walleij]

On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny <cheiny@xxxxxxxxxxxxx> wrote:

> diff --git a/drivers/input/Makefile b/drivers/input/Makefile
> index 09614ce..cfb383e 100644
> --- a/drivers/input/Makefile
> +++ b/drivers/input/Makefile
> @@ -23,6 +23,6 @@ obj-$(CONFIG_INPUT_TABLET)    += tablet/
>  obj-$(CONFIG_INPUT_TOUCHSCREEN)        += touchscreen/
>  obj-$(CONFIG_INPUT_MISC)       += misc/
>
> -obj-$(CONFIG_INPUT_APMPOWER)   += apm-power.o
> +obj-$(CONFIG_INPUT_RMI4) += rmi4/
>
> -obj-$(CONFIG_XEN_KBDDEV_FRONTEND)      += xen-kbdfront.o
> +obj-$(CONFIG_INPUT_APMPOWER)   += apm-power.o

Don't touch the other stuff, you just deleted the Xen Kbddev here!

> diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig
(...)
> +config RMI4_BUS
> +       bool "Synaptics RMI4 bus support"
> +       help
> +         Say Y here if you want to support the Synaptics RMI4 bus.  This is
> +         required for all RMI4 device support.
> +
> +         If unsure, say Y.

Are RMI4 devices so common that this should be the recommendation?

Also put the debug options into this file instead of random local
#defines in the other files.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/