Re: Regression associated with commit c8628155ece3 - "tcp: reduceout_of_order memory use"

From: Larry Finger
Date: Mon Aug 27 2012 - 13:55:38 EST


On 08/24/2012 12:47 PM, Eric Dumazet wrote:

dev_alloc_skb() can return NULL

-> crash

skb_clone() can also return NULL

-> crash

I have prepared a patch to fix all the unchecked allocations.

Over the weekend I made some progress. To test the latest vendor driver, I installed a 32-bit system. Their driver is not compatible with a 64-bit system. I found that not only did the vendor driver work with secure sites, but so did the in-kernel version. I now have tcpdump output for the 32-bit case that works, and the 64-bit case that fails. It seems likely that I missed some 32/64 bit incompatibility when I did the conversion.

Thanks for all your help in trying to resolve this issue.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/