Re: [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES

From: Oleg Nesterov
Date: Mon Aug 27 2012 - 13:42:12 EST


Srikar, this is still waiting for your review ;)

FYI, I created the tree to accumulate the acked patches,
kernel.org:/pub/scm/linux/kernel/git/oleg/misc

Currently it has:

Oleg Nesterov (7):
uprobes: kill uprobes_state->count
uprobes: kill dup_mmap()->uprobe_mmap(), simplify uprobe_mmap/munmap
uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending()
uprobes: do not use -EEXIST in install_breakpoint() paths
uprobes: introduce MMF_HAS_UPROBES
uprobes: fold uprobe_reset_state() into uprobe_dup_mmap()
uprobes: remove "verify" argument from set_orig_insn()

Sebastian Andrzej Siewior (1):
uprobes: remove check for uprobe variable in handle_swbp()

Srikar Dronamraju (1):
uprobes: Remove redundant lock_page/unlock_page

You didn't ack Sebastian's patch, but it looks simple. If you
have any objections please let me know.

On 08/19, Oleg Nesterov wrote:
>
> Hello.
>
> On top of "kill uprobes_state->count, add MMF_HAS_UPROBES"
> series.
>
> Once again, I am not sure we really need this (except 1/3).
> Perhaps we could remove uprobe_munmap() instead and forget
> about the false-positive MMF_HAS_UPROBES's.
>
> OTOH, imho it looks a bit more clean this way. Please comment.
>
> diffstat reports the code bloat, but note that the previous
> series removed more code.
>
> Oleg.
>
> include/linux/sched.h | 3 +-
> kernel/events/uprobes.c | 82 +++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 67 insertions(+), 18 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/