Re: [ 08/32] drm/i915: correctly order the ring init sequence

[Greg Kroah-Hartman]

On Fri, Aug 24, 2012 at 08:03:14PM -0300, Herton Ronaldo Krzesinski wrote:
> On Sun, Aug 19, 2012 at 08:57:04PM -0700, Greg Kroah-Hartman wrote:
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > 3.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > 
> > commit 0d8957c8a90bbb5d34fab9a304459448a5131e06 upstream.
> > 
> > We may only start to set up the new register values after having
> > confirmed that the ring is truely off. Otherwise the hw might lose the
> > newly written register values. This is caught later on in the init
> > sequence, when we check whether the register writes have stuck.
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50522
> > Tested-by: Yang Guang <guang.a.yang@xxxxxxxxx>
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> I think with this commit also the following commits should be picked for
> 3.4 right? (as suggested for 3.0):
> 
> f01db988ef6f6c70a6cc36ee71e4a98a68901229
> b7884eb45ec98c0d34c7f49005ae9d4b4b4e38f6
> 
> Just reporting that I tested this 3.4.10 proposed update with the two
> commits above cherry-picked/backported applied, and worked ok.

3.4.10 as-is works fine for me, so I'm a bit leary of wanting to add
more patches to it (or 3.0.42), until I get some kind of confirmation
that these two patches are really needed.

Anyone else having problems here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/