Re: [ 40/46] KVM: PIC: call ack notifiers for irqs that are droppedform irr

From: Greg Kroah-Hartman
Date: Sat Aug 25 2012 - 22:31:19 EST


On Thu, Aug 23, 2012 at 01:02:55AM +0100, Ben Hutchings wrote:
> On Sun, 2012-08-19 at 20:59 -0700, Greg Kroah-Hartman wrote:
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> > 3.5-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Gleb Natapov <gleb@xxxxxxxxxx>
> >
> > (cherry picked from commit aea218f3cbbcaac249b6b2c98930a00d6d931f1e)
> >
> > After commit 242ec97c358256 PIT interrupts are no longer delivered after
> > PIC reset. It happens because PIT injects interrupt only if previous one
> > was acked, but since on PIC reset it is dropped from irr it will never
> > be delivered and hence acknowledged. Fix that by calling ack notifier on
> > PIC reset.
> [...]
>
> Based on the commit blamed for the regression, I think this is needed
> for 3.4 as well.

That's up to Avi and Marcelo, as I do not apply any KVM patches to any
stable tree unless they say so (as they have asked in the past.)

Avi and Marcelo?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/