Re: [PATCH v2 1/2] apple-gmux: Fix index read functions

From: Seth Forshee
Date: Sat Aug 25 2012 - 20:48:56 EST


On Sat, Aug 25, 2012 at 10:30:48AM +0200, Bernhard Froemel wrote:
> From: Bernhard Froemel <froemel@xxxxxxxxxxxxxxxxxx>
>
> Study of Apple's binary driver revealed that the GMUX_READ_PORT should
> be written between calls to gmux_index_wait_ready and
> gmux_index_wait_complete (i.e., the new index protocol must be
> followed). If this is not done correctly, the indexed
> gmux device only partially accepts writes which lead to problems
> concerning GPU switching. Special thanks to Seth Forshee who helped
> greatly with identifying unnecessary changes.
>
> Signed-off-by: Bernhard Froemel <froemel@xxxxxxxxxxxxxxxxxx>

This does better match what Apple's driver does. Thanks Bernhard.

Acked-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/