Re: Unable to mount NFSROOT: pcie change breaks e1000?

From: Jiang Liu
Date: Fri Aug 24 2012 - 10:42:10 EST


On 08/24/2012 12:12 AM, Bjorn Helgaas wrote:
> On Thu, Aug 23, 2012 at 9:03 AM, Jiang Liu <liuj97@xxxxxxxxx> wrote:
>> Hi Bjorn,
>> Could you please help to fold this small patch into
>> "[5/40] PCI/core: Use PCI Express Capability accessors"?
>> It fixes a bug reported by Fengguang.
>
> Thanks, I folded it in. I looked briefly at whether a similar fix is
> needed in pci_restore_pcie_state(). I don't *think* so, but it
> wouldn't hurt for you to also double-check and let me know if it does.

I think it's optional to add a "pci_is_pcie()" check for pci_restore_pcie_state().
pci_find_saved_cap(dev, PCI_CAP_ID_EXP) should return NULL for non-PCIe device.

--Gerry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/